[xmppd-dev] Build failure of jabberd1.4 1.6.1.1 with g++ 4.4.1

[Michael Bienia]

Hello,

during a build test in Ubuntu, a build failure was discovered when
building jabberd14 with g++ 4.4.1:

xmlnode.cc: In function 'xmlnode_list_item_t*
xmlnode_get_tags(xmlnode_t*, const char*, xht_struct*, pool_struct*)':
xmlnode.cc:913: error: invalid conversion from 'const char*' to 'char*'
xmlnode.cc:914: error: invalid conversion from 'const char*' to 'char*'

xmlnode.cc: In function 'xmlnode_t*
xmlnode_select_by_lang(xmlnode_list_item_t*, const char*)':
xmlnode.cc:1836: error: assignment of read-only location '* strchr(lang, 45)'

Attached is a patch to fix those. While fixing the second one (in
xmlnode_select_by_lang), I think I found a bug:
According to the function description a lang of e.g. fr-FR should take
precedence to 'fr' (general_lang), but the code in line 1835+1836 strips
the variant from lang instead of general_lang and turning this ordering
in effect.

Regards,
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_invalid_conversion.patch
Type: text/x-diff
Size: 2114 bytes
Desc: not available
URL: <http://lists.xmppd.org/pipermail/dev/attachments/20090914/6c582472/attachment-0001.patch>